refactor: replace mime-types library with minimal helper#549
Merged
Conversation
mime-types@3.0.2 (CJS) calls require("path") inside ESM bundles causing
runtime errors. Replace it with a lightweight lookupMimeType helper that
covers the six extensions actually used (.png, .jpg, .jpeg, .gif, .webp,
.pdf).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mime-types(CJS) dependency that causedrequire("path")errors in ESM bundleslookupMimeTypehelper inapps/base/src/lib/mime.tscovering the 6 used extensionsread-image-file.tsandread-pdf-file.tsto use the new helpermime-typesand@types/mime-typesfromapps/base/package.jsonTest plan
pnpm typecheck— 23/23 passpnpm build— 23/23 passpnpm test— all unit tests pass🤖 Generated with Claude Code